RFR: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build [v2]

Kevin Walls kevinw at openjdk.org
Wed Jan 31 10:22:02 UTC 2024


On Wed, 31 Jan 2024 10:15:06 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> test_nmt_locationprinting.cpp defines method test_for_dead_c_heap_block unconditionally, but this method is only ever used on Linux. In the gcc windows build this fires an unused method warning and breaks the gtest suite. Since this is never used outside of Linux, make this method's definition only appear on Linux to avoid polluting code on other platforms
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Copyright test_nmt_locationprinting.cpp

Looks good.

-------------

Marked as reviewed by kevinw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17612#pullrequestreview-1853376583


More information about the hotspot-runtime-dev mailing list