RFR: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages [v2]

Thomas Stuefe stuefe at openjdk.org
Mon Jul 1 06:43:20 UTC 2024


On Mon, 1 Jul 2024 06:14:24 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> src/hotspot/os/aix/os_aix.cpp line 472:
>> 
>>> 470:         munmap(p, 64*K);
>>> 471:       }
>>> 472:     }
>> 
>> Why MAP_SHARED?
>
> Sorry Thomas, I oversaw your question.
> I followed the the code of reserve_mmaped_memory(), where MAP_SHARED is used with the following comment:
> 
> 
>   // Note: MAP_SHARED (instead of MAP_PRIVATE) needed to be able to
>   // later use msync(MS_INVALIDATE) (see os::uncommit_memory).
>   int flags = MAP_ANONYMOUS | MAP_SHARED;
> 
> 
> I would like to have set the same flags for this test as used later on in real life.

Okay.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19771#discussion_r1660544222


More information about the hotspot-runtime-dev mailing list