RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v5]

Kevin Walls kevinw at openjdk.org
Mon Jul 1 12:59:21 UTC 2024


On Mon, 1 Jul 2024 07:19:48 GMT, Sebastian Lövdahl <duke at openjdk.org> wrote:

>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adapt code style

Looks good to me, thanks!

(!havePidNSes && nsPid > 1)
I didn't get this at first, I think it's because PID 1 can't have a parent? (in the same namespace)

-------------

Marked as reviewed by kevinw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19055#pullrequestreview-2151324535
PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2200071296


More information about the hotspot-runtime-dev mailing list