RFR: JDK-8334217 : [AIX] Misleading error messages after JDK-8320005 [v6]

[Joachim Kern]

On Wed, 3 Jul 2024 15:12:32 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> dll_load_library() call fails is not analyzed (the ebuf content is ignored)
>> dll_load_library does not analyze the contents of ebuf which leads to misleading error message when library loading fails.
>> 
>> We now call  the second dll_load_library() only if the first returns with a 'No such file or directory' error message.
>> If the first dll_load_library() found the library is not able to load it by any reason, we do not try again with a .a extension.
>> [JDK-8334217](https://bugs.openjdk.org/browse/JDK-8334217)
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   semicolon

Changes requested by jkern (Committer).

src/hotspot/os/aix/os_aix.cpp line 1019:

> 1017:   const char* error_report = nullptr;
> 1018:   JFR_ONLY(NativeLibraryLoadEvent load_event(filename, &result);)
> 1019:   result = Aix_dlopen(filename, eno, dflags, &error_report);

Please switch dflags and eno
 old:    result = Aix_dlopen(filename, eno, dflags, &error_report);
 new:  result = Aix_dlopen(filename, dflags, eno, &error_report);

-------------

PR Review: https://git.openjdk.org/jdk/pull/19887#pullrequestreview-2156781922
PR Review Comment: https://git.openjdk.org/jdk/pull/19887#discussion_r1664391446