RFR: JDK-8334217 : [AIX] Misleading error messages after JDK-8320005 [v6]

Joachim Kern jkern at openjdk.org
Wed Jul 3 15:39:25 UTC 2024


On Wed, 3 Jul 2024 15:09:19 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> src/hotspot/os/aix/porting_aix.cpp line 1038:
>> 
>>> 1036: // This way we mimic dl handle equality for a library
>>> 1037: // opened a second time, as it is implemented on other platforms.
>>> 1038: void* Aix_dlopen(const char* filename, int *eno, int Flags, const char** error_report) {
>> 
>> I think you also have to adapt the `Aix_dlopen()` declaration in the header file `porting_aix.hpp`
>
> Ok. I understood. The reason i was not getting error was i was compiling on Linux machine. I thought the jdk would throw errors atleast.

Please switch Flags and eno
old: void* Aix_dlopen(const char* filename, int *eno, int Flags, const char** error_report) {
new: void* Aix_dlopen(const char* filename, int Flags, int *eno, const char** error_report) {

and I have to emphasize please also add this additional `int *eno` to the declaration of `Aix_dlopen()` in the `porting_aix.hpp` file

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19887#discussion_r1664397524


More information about the hotspot-runtime-dev mailing list