RFR: JDK-8334217 : [AIX] Misleading error messages after JDK-8320005 [v6]

Suchismith Roy sroy at openjdk.org
Wed Jul 3 15:43:24 UTC 2024


On Wed, 3 Jul 2024 15:31:23 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   semicolon
>
> src/hotspot/os/aix/os_aix.cpp line 1019:
> 
>> 1017:   const char* error_report = nullptr;
>> 1018:   JFR_ONLY(NativeLibraryLoadEvent load_event(filename, &result);)
>> 1019:   result = Aix_dlopen(filename, eno, dflags, &error_report);
> 
> Please switch dflags and eno
>  old:    result = Aix_dlopen(filename, eno, dflags, &error_report);
>  new:  result = Aix_dlopen(filename, dflags, eno, &error_report);

ok. why are we switching the order of arguments  / parameters ? is it some order of the arguments to be processed ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19887#discussion_r1664404398


More information about the hotspot-runtime-dev mailing list