RFR: JDK-8334217 : [AIX] Misleading error messages after JDK-8320005 [v7]

[Joachim Kern]

On Wed, 3 Jul 2024 16:02:31 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> dll_load_library() call fails is not analyzed (the ebuf content is ignored)
>> dll_load_library does not analyze the contents of ebuf which leads to misleading error message when library loading fails.
>> 
>> We now call  the second dll_load_library() only if the first returns with a 'No such file or directory' error message.
>> If the first dll_load_library() found the library is not able to load it by any reason, we do not try again with a .a extension.
>> [JDK-8334217](https://bugs.openjdk.org/browse/JDK-8334217)
>
> Suchismith Roy has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - name correction
>  - order of arguments and parameters
>  -  header

src/hotspot/os/aix/porting_aix.cpp line 1038:

> 1036: // This way we mimic dl handle equality for a library
> 1037: // opened a second time, as it is implemented on other platforms.
> 1038: void* Aix_dlopen(const char* filename,int Flags, int *eno, const char** error_report) {

Please insert a space between ',' and 'int Flags'.
Otherwise it looks good now and I will check with a testbuild.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19887#discussion_r1665347615