RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction

[Kevin Walls]

On Thu, 4 Jul 2024 09:24:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

> But if it can't be empty can we not just assert that and get rid of the is_empty check from is_executable? 

Yes, we might be able to do that.
I was going for just the obvious logic correction, because it's distracting to read through things that look wrong.  
Looking at it again today I'm still not sure if we should restrict it so a CmdLine can never be empty in some future usage.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20006#issuecomment-2208968382