RFR: 8332124: Jcmd should recognise options that look like requests for help [v7]
Kevin Walls
kevinw at openjdk.org
Thu Jul 4 15:05:21 UTC 2024
On Thu, 4 Jul 2024 14:43:49 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) enabling jcmd to recognize options that look like help.
>>
>> Testing:
>> - [x] Added test case passes.
>>
>> Thanks,
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8332124
> - Updates based on feedback. Moving resource mark, updating commets and test
> - Updating comments
> - Enabling -help to work as well. Updating test cases
> - Making enabling help more restrictive. Will not accept -help
> - Enabling only -h or --help. Also modifying test case
> - Updating copyright header
> - Modifying usage to --help and -help. Updated ensuing test case to test both
> - Updating copyright headers
> - Merge branch 'openjdk:master' into JDK-8332124
> - ... and 2 more: https://git.openjdk.org/jdk/compare/71afd15b...6b52c091
Looks good to me, I think it's done, thanks for you patience.
-------------
Marked as reviewed by kevinw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19776#pullrequestreview-2159124074
More information about the hotspot-runtime-dev
mailing list