RFR: 8315231: runtime/cds/appcds/dynamicArchive/RedefineCallerClassTest.java timed out

[David Holmes]

On Wed, 10 Jul 2024 18:57:09 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> When this test is run with the `-Xcomp -UseAVX=3` VM options, the `test.timeout.factor` is set to 4 (default value) which is insufficient in some platforms especially on Windows. Increasing the timeout value for this test. If later more tests are timing out, we can consider increasing the `test.timeout.factor` for all the tests running with the above VM options.
> 
> Testing: ran the test 20 times with the `-Xcomp -UseAVX=3` VM options on windows-x64 and linux-x64 platforms.

>From what I can see the longest a successful run of the test takes on Windows is < 14m, so < 840s.

You changed the timeout from the default of 120 * 4 = 480s, to 360 * 4 = 1440s, so that seems like it should be enough. However, in some test runs (those where it takes up to 14m), the timeout factor is actually 10 (so 20m), so this has the affect of greatly increasing the allowed timeout (30m) in those other tiers.

I think this should be fixed in our task definitions - see comment in JBS.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20121#pullrequestreview-2170760989