RFR: 8336080: Fix -Wzero-as-null-pointer-constant warnings in ClassLoaderStats ctor

Kim Barrett kbarrett at openjdk.org
Tue Jul 16 17:47:51 UTC 2024


On Tue, 16 Jul 2024 05:54:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this change to member initializers in the ClassLoaderStats
>> constructor.
>> 
>> The initial value for members of pointer type are changed from 0 to nullptr.
>> 
>> The initializers for members of oop type are changed from a value of 0 to
>> using value initialization. In debug builds this calls the provided default
>> ctor for the (debug-only) oop class, which initialized the underlying value to
>> nullptr. In release builds (where oop is a type alias for oopDesc*) this is a
>> zero initialization of the pointer-typed member, but without triggering
>> -Wzero-as-null-pointer-constant warnings.
>> 
>> Testing: mach5 tier1
>
> Marked as reviewed by dholmes (Reviewer).

Thanks for reviews @dholmes-ora and @walulyai

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20109#issuecomment-2231478663


More information about the hotspot-runtime-dev mailing list