RFR: 8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test [v3]

Wed Jul 17 20:03:35 UTC 2024

On Wed, 17 Jul 2024 08:39:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> I was initially concerned we are narrowing to `int` to please the format specifiers. Normally, I would have expected us to work out a format specifier based on `time_t` size, and put it in `globalDefinitions.hpp`. But this looks okay as the unblocking fix.

Hmm, actually [`long        tm_gmtoff;`](https://github.com/vpa1977/jdk/blob/ff97727f9a7141451dcc9a2565d277368c4b5d99/src/hotspot/share/runtime/os.cpp#L183) is getting assigned to time_t and in the alternate branch we are doing a [static cast](https://github.com/vpa1977/jdk/blob/ff97727f9a7141451dcc9a2565d277368c4b5d99/src/hotspot/share/runtime/os.cpp#L187C6-L187C7). I guess the correct fix should've been changing [UTC_to_local](https://github.com/vpa1977/jdk/blob/ff97727f9a7141451dcc9a2565d277368c4b5d99/src/hotspot/share/runtime/os.cpp#L180) to long.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19782#issuecomment-2234152783