RFR: 8301403: Eliminate memory allocations in JVMFlag::printFlags during signal handling [v3]

David Holmes dholmes at openjdk.org
Thu Jul 18 05:53:32 UTC 2024


On Thu, 18 Jul 2024 05:34:50 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> I still dislike the misuse of the enum. Among other things, this is not threadsafe, 

I was under the impression the rest of the flag bits were immutable, hence no actual thread-safety issue for hs_err reporting. But yes in general this does make printFlags not-thread-safe. Your alternative bitmap design sounds reasonable.

> Nobody talks about removing the decoder; I meant removing malloc from the decoder.

I was under the impression that would be very difficult to do (not that I've looked into it) - hence the acceptance of its use. A malloc-less decoder doesn't sound trivial.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20202#issuecomment-2235593643


More information about the hotspot-runtime-dev mailing list