RFR: 8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test [v3]

[Aleksey Shipilev]

On Tue, 16 Jul 2024 03:00:06 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:

>> Due to time_t transition time_t is now 64bit on Ubuntu. zone_hours and zone_min are printed using %02d specifier. This causes random value to be printed as the timezone offset.
>> 
>> Testing - armhf gtest passes on Ubuntu Oracular:
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    gtest:all/server                                   1033  1033     0     0   
>> ==============================
>> TEST SUCCESS
>
> Vladimir Petko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add static_cast<int> to avoid -Wconversion warnings.

Sorry, I did not mean that a follow-up work would be needed. I agree the cast is fine. It would probably be a bit less confusing to me to cast right in `printf` argument block, so it would be obvious no calculations are affected, and we are really only catering for the format specifiers. But this is a minor thing that does not deserve a follow-up, really.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19782#issuecomment-2235828659