RFR: 8301403: Eliminate memory allocations in JVMFlag::printFlags during signal handling [v5]

[David Holmes]

On Sun, 21 Jul 2024 09:10:35 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   can not use new
>
> src/hotspot/share/runtime/flags/jvmFlag.cpp line 710:
> 
>> 708:     size_t best_i = 0;
>> 709:     for (size_t i = 0; i < length; i++) {
>> 710:       if (!iteratorMarkers.at(i) && flagTable[i].is_unlocked() && !(skipDefaults && flagTable[i].is_default())) {
> 
> Why does `!(skipDefaults && flagTable[i].is_default())` compute `flagTable[i].is_default()` if `skipDefaults = true`?

Because if they are both true we negate and skip. ???

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20202#discussion_r1685824088