RFR: 8301403: Eliminate memory allocations in JVMFlag::printFlags during signal handling [v5]

Thomas Stuefe stuefe at openjdk.org
Tue Jul 23 10:18:36 UTC 2024


On Mon, 22 Jul 2024 19:14:28 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Because if they are both true we negate and skip. ???
>
> I missed that this is pre-existent. Now that I read it, I get it, it really didn't click yesterday. "Check if it's default, and if we should skip defaults then skip it."

It would benefit from clearer coding.

E.g. 

const bool skip = ...
const bool visited = ...
if (!visited && !skip) ...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20202#discussion_r1687806919


More information about the hotspot-runtime-dev mailing list