RFR: 8334085: Test crash: assert(thread->held_monitor_count() == 0) failed: Must be [v3]

Serguei Spitsyn sspitsyn at openjdk.org
Wed Jul 24 21:43:44 UTC 2024


On Wed, 24 Jul 2024 21:08:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added a comment explaining why extra yield is needed
>
> test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/GetOwnedMonitorInfoTest.java line 56:
> 
>> 54: 
>> 55:     private static void jniMonitorEnterAndLetObjectDie() {
>> 56:         // The monitor iterator used by GetOwnedMonitorInfo to
> 
> The original was correct "used to assert"

The original was: "used by GetOwnedMonitorInfo used to assert".
The word "used" is repeated twice.
Changed to: "used by GetOwnedMonitorInfo to assert".
Do I miss anything?

> test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/GetOwnedMonitorInfoTest.java line 90:
> 
>> 88: 
>> 89:                 // Extra unmount helps to reproduce 8334085.
>> 90:                 // Two sub-sequential thaws are needed in that sceanrio.
> 
> s/sceanrio/scenario

Sorry for the typo. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20294#discussion_r1690483888
PR Review Comment: https://git.openjdk.org/jdk/pull/20294#discussion_r1690484412


More information about the hotspot-runtime-dev mailing list