RFR: 8336919: Cleanup and rename tags in placeholders code

[Coleen Phillimore]

On Mon, 22 Jul 2024 16:17:37 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This change does some renaming of tags, fields and function name (resolve_super_or_fail => resolve_with_circularity_detection) in the Placeholders and SystemDictionary (class loading) code.  resolve_super_or_fail implied that it's always the super class, which it is not, especially with the upcoming changes to valhalla.  Renaming the function to resolve/load and check for circularity error is more accurate. These are changes made by @fparain brought over from the valhalla branch.
> Tested with tier1-4.

David, thank you for your detailed comments.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20279#pullrequestreview-2199099978