RFR: 8336919: Cleanup and rename tags in placeholders code [v2]

[Coleen Phillimore]

> This change does some renaming of tags, fields and function name (resolve_super_or_fail => resolve_with_circularity_detection) in the Placeholders and SystemDictionary (class loading) code.  resolve_super_or_fail implied that it's always the super class, which it is not, especially with the upcoming changes to valhalla.  Renaming the function to resolve/load and check for circularity error is more accurate. These are changes made by @fparain brought over from the valhalla branch.
> Tested with tier1-4.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Fix indentiation, add some comments and revert resolve_super_or_fail name to be a wrapper for resolve_with_circularity_detection.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20279/files
  - new: https://git.openjdk.org/jdk/pull/20279/files/07193660..83741cd6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20279&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20279&range=00-01

  Stats: 53 lines in 5 files changed: 15 ins; 8 del; 30 mod
  Patch: https://git.openjdk.org/jdk/pull/20279.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20279/head:pull/20279

PR: https://git.openjdk.org/jdk/pull/20279