RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction
David Holmes
dholmes at openjdk.org
Mon Jul 29 01:36:40 UTC 2024
On Wed, 3 Jul 2024 13:58:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
> CmdLine::is_executable() looks wrong, surely an empty line is not executable.
>
> With this change, in DCmd::parse_and_execute() we will avoid needlessly entering the code block to try and execute the command.
>
> DCmd tests all good:
> make images test TEST="test/hotspot/jtreg/serviceability/dcmd test/jdk/sun/tools/jcmd"
Code fix is good. Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20006#pullrequestreview-2203679120
More information about the hotspot-runtime-dev
mailing list