RFR: 8336919: Cleanup and rename tags in placeholders code [v4]

[David Holmes]

On Mon, 29 Jul 2024 12:16:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change does some renaming of tags, fields and function name (resolve_super_or_fail => resolve_with_circularity_detection) in the Placeholders and SystemDictionary (class loading) code.  resolve_super_or_fail implied that it's always the super class, which it is not, especially with the upcoming changes to valhalla.  Renaming the function to resolve/load and check for circularity error is more accurate. These are changes made by @fparain brought over from the valhalla branch.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix some comments

Okay. I hope all the comments do get suitably updated though - and soon, as things are a bit confusing whilst we are in this interim state.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20279#pullrequestreview-2206395209