RFR: 8336919: Cleanup and rename tags in placeholders code [v4]

[Ioi Lam]

On Mon, 29 Jul 2024 12:16:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change does some renaming of tags, fields and function name (resolve_super_or_fail => resolve_with_circularity_detection) in the Placeholders and SystemDictionary (class loading) code.  resolve_super_or_fail implied that it's always the super class, which it is not, especially with the upcoming changes to valhalla.  Renaming the function to resolve/load and check for circularity error is more accurate. These are changes made by @fparain brought over from the valhalla branch.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix some comments

Changes requested by iklam (Reviewer).

src/hotspot/share/classfile/systemDictionary.cpp line 509:

> 507:   // The only thing that takes different action for is_superclass is dumping the static archive, which doesn't
> 508:   // reach this path.
> 509:   assert (!CDSConfig::is_dumping_static_archive(), "should not be dumping static archive");

I don't think this assert is correct.

It may be true that *some* calls made by CDS will not come to here (i.e., the code with the `// Special processing for handling UNREGISTERED shared classes` comment).

However, it's not guaranteed that EVERY call made when dumping the static archive will not come to here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20279#pullrequestreview-2209137072
PR Review Comment: https://git.openjdk.org/jdk/pull/20279#discussion_r1697881193