RFR: 8336919: Cleanup and rename tags in placeholders code [v5]

[Coleen Phillimore]

On Wed, 31 Jul 2024 12:36:05 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change does some renaming of tags, fields and function name (resolve_super_or_fail => resolve_with_circularity_detection) in the Placeholders and SystemDictionary (class loading) code.  resolve_super_or_fail implied that it's always the super class, which it is not, especially with the upcoming changes to valhalla.  Renaming the function to resolve/load and check for circularity error is more accurate. These are changes made by @fparain brought over from the valhalla branch.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove archive for dumping static archive.  The is_superclass parameter always true may or may not reach the code that's wrong.

Thanks David, Ioi and Fred for the code reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20279#issuecomment-2261053111