RFR: 8333290: NMT report should not print Metaspace info if Metaspace is not yet initialized
David Holmes
dholmes at openjdk.org
Sat Jun 1 05:56:02 UTC 2024
On Fri, 31 May 2024 07:07:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Somewhat trivial fix to a small initialization problem ubsan uncovered.
>
> If hs-err file gets dumped after NMT initialization but before Metaspace initialization, we may see secondary crashes during error log writing, since NMT reports contain metaspace counters, and those are not ready yet. We should omit that info if metaspace has not yet been initialized.
>
> (See prior discussions in https://github.com/openjdk/jdk/pull/19435)
Looks good! Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19493#pullrequestreview-2092024130
More information about the hotspot-runtime-dev
mailing list