RFR: 8307824: Clean up Finalizable.java and finalize terminology in vmTestbase/nsk/share [v3]

Leonid Mesnik lmesnik at openjdk.org
Mon Jun 3 23:02:28 UTC 2024


On Fri, 31 May 2024 19:58:34 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   moved return out of try/catch
>
> test/hotspot/jtreg/vmTestbase/nsk/share/aod/DummyTargetApplication.java line 68:
> 
>> 66:         if ((signal == null) || !signal.equals(AODTestRunner.SIGNAL_FINISH))
>> 67:             throw new TestBug("Unexpected signal: '" + signal + "'");
>> 68:         pipe.close();
> 
> Exceptions can be thrown before you get here.

Thanks, updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19505#discussion_r1623281376


More information about the hotspot-runtime-dev mailing list