RFR: 8333326: Linux Alpine build fails after 8302744
Thomas Stuefe
stuefe at openjdk.org
Tue Jun 4 07:46:07 UTC 2024
On Tue, 4 Jun 2024 07:38:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Thanks @jerboaa I obviously completely missed that. :(
>>
>> But as per Thomas's comment we should be using the Posix function not glibc version. Then we would not need to specialize for Musl-C.
>
> So should I remove the ifdef MUSL_LIBC ?
> I considered this but was not sure because it might change more than just fixing the Alpine build.
Yes, you can remove it. Both libc's actually require libgen.h for basename.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19497#discussion_r1625517326
More information about the hotspot-runtime-dev
mailing list