RFR: 8333326: Linux Alpine build fails after 8302744 [v2]

Matthias Baesken mbaesken at openjdk.org
Tue Jun 4 13:03:32 UTC 2024


> we run into a basename related build issue on Alpine Linux
> 
> basename related issue :
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-linux_alpine_x86_64-opt/jdk/test/hotspot/gtest/runtime/test_cgroupSubsystem_linux.cpp: In member function 'virtual void cgroupTest_read_numerical_key_value_success_cases_Test::TestBody()':
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-linux_alpine_x86_64-opt/jdk/test/hotspot/gtest/runtime/test_cgroupSubsystem_linux.cpp:139:19: error: 'basename' was not declared in this scope; did you mean 'rename'?
>   139 | const char* b = basename(test_file);
>       | ^~~~~~~~
>       | rename
> 
> 
> Additionally giving a 'const char*'  to basename results in a warning as error because basename interface gets a char* .

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  use libgen basename not only on Alpine

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19497/files
  - new: https://git.openjdk.org/jdk/pull/19497/files/834b68f9..fabfcd22

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19497&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19497&range=00-01

  Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19497.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19497/head:pull/19497

PR: https://git.openjdk.org/jdk/pull/19497


More information about the hotspot-runtime-dev mailing list