RFR: 8313562: hsperfdata should export module path and "launcher" metadata [v3]

[Kevin Walls]

On Wed, 5 Jun 2024 01:11:14 GMT, Larry Cable <duke at openjdk.org> wrote:

>> hsperfdata should expose module metadata if available.
>
> Larry Cable has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8313562: added add_optional_property_constant to deal with null valued module properties

The update is good, yes those can be nulls 8-)

Do you see a compiler warning for the if being all on one line, in line 239 of statSampler.cpp?  I do, locally, and I need to use if () { } to avoid a build failure.


Then running with: --module-path=/foo
I see:

jcmd 14540 PerfCounter.print | grep -i modu
java.property.jdk.module.path="/foo"
java.rt.vmArgs="--module-path=/foo"
jdk.module.finder.modulepath.modules=0
jdk.module.finder.modulepath.scanTime=10411013


JDK-8313562 doesn't specify what information will be included and what perfdata names will be, but I think this is what was intended.

Maybe a (C) update while you're there, and it's done.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19287#pullrequestreview-2098525194