RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v7]
Alan Bateman
alanb at openjdk.org
Wed Jun 5 17:42:58 UTC 2024
On Wed, 5 Jun 2024 15:58:28 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Thanks !
>>
>> Your PR looks very promising @tstuefe, I would indeed prefer to wait for your changes as a way to add additional indentation to the stack of the virtual thread.
>>
>> What do you think if I leave the current PR with the indentation that is already used for the stack of the carrier thread and I create a separate PR based on yours to add the additional indentation ?
>
> Okay for me, if other reviewers are okay with it.
I think it would be better if the stack trace of the mounted virtual thread didn't align/indent the same as the carrier as it kinda looks like it's one larger stack trace. That said, no objection if there is a follow-on PR to do that, in which case might be better to wait until after the fork for JDK 23 so that the two PRs go into the same release.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1628172341
More information about the hotspot-runtime-dev
mailing list