RFR: 8306580: Propagate CDS dumping errors instead of directly exiting the VM [v3]
Matias Saavedra Silva
matsaave at openjdk.org
Wed Jun 5 21:26:01 UTC 2024
> Currently, when CDS dumping run into an unrecoverable error (e.g., file I/O error, out of memory), it calls MetaspaceShared::unrecoverable_writing_error(), which directly exits the VM. Some of these errors can be propagated to the caller for a normal exit.
>
> This change introduces `MetaspaceShared::writing_error()` to report errors without exiting the VM. The function `MetaspaceShared::unrecoverable_writing_error()` now should only be used for errors that require the VM to exit. Verifier with tier1-5 tests.
Matias Saavedra Silva has updated the pull request incrementally with two additional commits since the last revision:
- Thomas comments and cleanup
- Added test for file errors
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19370/files
- new: https://git.openjdk.org/jdk/pull/19370/files/7f92425e..4e99c916
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19370&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19370&range=01-02
Stats: 72 lines in 5 files changed: 64 ins; 2 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/19370.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19370/head:pull/19370
PR: https://git.openjdk.org/jdk/pull/19370
More information about the hotspot-runtime-dev
mailing list