RFR: 8333522: JFR SwapSpace event might read wrong free swap space size [v2]

Severin Gehwolf sgehwolf at openjdk.org
Fri Jun 7 09:35:19 UTC 2024


On Fri, 7 Jun 2024 07:53:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> In some cgroups v2 based test system , a too large free swap space value has been observed.
>> The value should not be larger than total swap space.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add assert

Debug builds fail.

src/hotspot/os/linux/os_linux.cpp line 318:

> 316: jlong os::free_swap_space() {
> 317:   jlong host_free_swap_val = MIN2(os::total_swap_space(), host_free_swap());
> 318:   assert(host_free_swap_val >= 0, "sysinfo failed?")

Missing semicolon.

-------------

Changes requested by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19574#pullrequestreview-2104090665
PR Review Comment: https://git.openjdk.org/jdk/pull/19574#discussion_r1630937353


More information about the hotspot-runtime-dev mailing list