RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v8]

[Alan Bateman]

On Tue, 4 Jun 2024 08:06:28 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Inigo Mediavilla Saiz has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Cleanup test
>>    
>>    - Stop virtualthread
>>    - Remove unneeded imports
>>    - Remove modules that are not needed
>>  - Fix copyright year
>
> I think the presentation of the carrier the mounted virtual thread in update (b122cc05) looks quite good.
> 
> I think it would be helpful to include the thread name too. Many virtual threads are unnamed so it will show as "" but that is okay. In addition to being useful it means the format of the "Mounted virtual thread ..." line will be consistent the first part of the line for platform threads.
> 
> I'm wondering if we should remove the existing "Carrying virtual thread ..." line as part of this. It's redundant now, @pron ?

> @AlanBateman @dholmes-ora would you be OK with leaving the current PR as-is and handling the indentation topic in a separate PR ?

I assume the follow-up to improve the alignment will be a small change. No objection if you do it here or in a follow-up PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19482#issuecomment-2160047420