RFR: 8332362: Implement os::committed_in_range for MacOS and AIX [v2]

Robert Toyonaga duke at openjdk.org
Tue Jun 11 14:16:26 UTC 2024


> ### Summary
> This change adds `os::committed_in_range` to `src/hotspot/os/posix/os_posix.cpp` so that AIX and MacOS can use it. It is mostly the same as the prior implementation in `os_linux.cpp`, but takes into account AIX may have unaligned stacks and variable page sizes, and that mincore uses a different argument type on linux.  This will allow AIX and MacOS to report true liveness information for thread stacks reported by NMT. Previously this was only possible on Windows and Linux.
> 
> **Testing**
> - `TestAlwaysPreTouchStacks.java` is updated to also test the case when stacks are large but mostly not paged in. 
> - A few new unit tests in `test_committed_virtualmemory.cpp` to check`os::committed_in_range`. I've excluded these tests on Windows because it reports the committed region as fully paged in. 
> - tier1
> 
> I've tested on Linux and Windows. I don't have a Mac to test on, but the Mac GHA tests are passing. Not yet tested on AIX.

Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:

  Remove debug log. Enable tests for aix.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19455/files
  - new: https://git.openjdk.org/jdk/pull/19455/files/1bc9acf3..1b8853cd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19455&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19455&range=00-01

  Stats: 4 lines in 3 files changed: 1 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19455.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19455/head:pull/19455

PR: https://git.openjdk.org/jdk/pull/19455


More information about the hotspot-runtime-dev mailing list