RFR: 8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer

[Matthias Baesken]

On Wed, 12 Jun 2024 06:19:19 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Looks good.
> 
> But could you add a define for this, please? Would be better to read. We already have ATTRIBUTE_NO_ASAN (see share/sanitizers). I think a corresponding ATTRIBUTE_NO_UBSAN would be good.
> 
> Such a define would also be the central place to switch on Visual Studio if they ever add ubsan support.

Thanks for the review !
Introducing ATTRIBUTE_NO_UBSAN sounds like a good idea, we could reuse that in vmerror.cpp too (function crash_with_sigfpe).
Where should I place the macro , maybe a separate header sanitizers/ub.hpp  next to sanitizers/address.hpp  ?
On the other hand, those defines would maybe be needed also outside HS in the JDK libs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19597#issuecomment-2162244008