RFR: 8334135: RISC-V: check vector support in VM_Version::os_aux_features
Hamlin Li
mli at openjdk.org
Wed Jun 12 14:50:19 UTC 2024
Hi,
Can you help to review this patch?
Previously, VM_Version::os_aux_features skips vector check, even if it knows vector is supported via HWCAP, because it can not tell if the rvv0.7 or rvv1.0 is supported, and jdk only supports rvv 1.0.
But this brings another issue in some situation where borad itself supports rvv1.0, but kernel does not support hw probe, then jdk can not enable UseRVV, but it should be.
The solution is to delete the skipping rvv check code, and does not care about if it supports 0.7 or 1.0. The result is, when rvv 1.0 is supported then user can get the feature from jdk; when rvv 0.7 is supported then user needs to pass "-XX:-UseRVV" to disable it explicitly.
Although the solution is not perfect, but I hope it will support both situations anyway.
Thanks!
-------------
Commit messages:
- Initial commmit
Changes: https://git.openjdk.org/jdk/pull/19679/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19679&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8334135
Stats: 11 lines in 1 file changed: 0 ins; 11 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/19679.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19679/head:pull/19679
PR: https://git.openjdk.org/jdk/pull/19679
More information about the hotspot-runtime-dev
mailing list