RFR: 8334135: RISC-V: check vector support in VM_Version::os_aux_features
Hamlin Li
mli at openjdk.org
Thu Jun 13 09:09:12 UTC 2024
On Wed, 12 Jun 2024 14:46:49 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
>
> Previously, VM_Version::os_aux_features skips vector check, even if it knows vector is supported via HWCAP, because it can not tell if the rvv0.7 or rvv1.0 is supported, and jdk only supports rvv 1.0.
> But this brings another issue in some situation where borad itself supports rvv1.0, but kernel does not support hw probe, then jdk can not enable UseRVV, but it should be.
> The solution is to delete the skipping rvv check code, and does not care about if it supports 0.7 or 1.0. The result is, when rvv 1.0 is supported then user can get the feature from jdk; when rvv 0.7 is supported then user needs to pass "-XX:-UseRVV" to disable it explicitly.
> Although the solution is not perfect, but I hope it will support both situations anyway.
>
> And I suppose more and more board will support rvv 1.0 rather than 0.7.
>
> Thanks!
Ah, I see what's the `only Linux Kernel v6.5+ supports V` mean now. Thanks for pointing out.
OK, then seems the board I just got is not good enough to test the RVV related features. Or, maybe I need more work to make it work, as my kernel now is `5.10.4`
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19679#issuecomment-2165070082
More information about the hotspot-runtime-dev
mailing list