RFR: 8306580: Propagate CDS dumping errors instead of directly exiting the VM [v4]

[Calvin Cheung]

On Tue, 11 Jun 2024 21:16:24 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Currently, when CDS dumping run into an unrecoverable error (e.g., file I/O error, out of memory), it calls MetaspaceShared::unrecoverable_writing_error(), which directly exits the VM.  Some of these errors can be propagated to the caller for a normal exit. 
>> 
>> This change introduces `MetaspaceShared::writing_error()` to report errors without exiting the VM. The function `MetaspaceShared::unrecoverable_writing_error()` now should only be used for errors that require the VM to exit. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Used ACLs for Windows directory
>  - Uses correct directory for Windows

Looks good. Found one nit in the test.

test/hotspot/jtreg/runtime/cds/StaticWritingError.java line 25:

> 23: 
> 24: /**
> 25:  * @test

Please add `@bug 8306580`.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19370#pullrequestreview-2117047985
PR Review Comment: https://git.openjdk.org/jdk/pull/19370#discussion_r1638959287