RFR: 8332113: Update nsk.share.Log to be always verbose [v2]
Chris Plummer
cjplummer at openjdk.org
Fri Jun 14 00:34:16 UTC 2024
On Fri, 14 Jun 2024 00:03:32 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 130:
>>
>>> 128: * Default value is <code>0</code> a.k.a. <code>TraceLevel.INFO</code>;
>>> 129: */
>>> 130: private final int traceLevel = TraceLevel.TRACE_DEBUG + 1;
>>
>> Can you explain this change?
>
> The intention is to print always all logged messages. So we should set the highest tracing level for the logger to work in debug mode.
I'm not so sure I agree with this. Do we have examples of debug logging? I think in general verbose logging has actually been used to produced a log of useful info, so always logging in verbose mode seems like a good idea, but I see debug logging as something beyond that, and may get too noisy.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19613#discussion_r1639074271
More information about the hotspot-runtime-dev
mailing list