RFR: 8321033: Avoid casting Array to GrowableArray [v3]

[Matias Saavedra Silva]

On Thu, 13 Jun 2024 21:44:59 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Ioi comments
>
> src/hotspot/share/classfile/moduleEntry.cpp line 212:
> 
>> 210: bool ModuleEntry::has_reads_list() const {
>> 211:   assert_locked_or_safepoint(Module_lock);
>> 212:   return ((_reads != nullptr) && !reads()->is_empty());
> 
> Could the first condition be `reads() != nullptr` ?

This was a vestige of the earlier version where the state booleans may not have been initialized. I believe it should ok to use `reads()` now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19549#discussion_r1639999193