RFR: 8333819: Move embedded external addresses from relocation info into separate global table [v2]

[Vladimir Kozlov]

On Mon, 17 Jun 2024 11:01:19 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address comments
>
> src/hotspot/share/code/oopRecorder.cpp line 229:
> 
>> 227: void ExternalsRecorder::initialize() {
>> 228:   // After Mutex and before CodeCache are initialized
>> 229:   _recorder = new ExternalsRecorder();
> 
> Can we assert that _recorder is null?

done

> src/hotspot/share/code/oopRecorder.hpp line 254:
> 
>> 252:   static ExternalsRecorder* _recorder;
>> 253:  public:
>> 254:   ExternalsRecorder();
> 
> Should this be private?

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19703#discussion_r1643015736
PR Review Comment: https://git.openjdk.org/jdk/pull/19703#discussion_r1643015513