RFR: 8332362: Implement os::committed_in_range for MacOS and AIX [v6]

Robert Toyonaga duke at openjdk.org
Mon Jun 17 15:43:16 UTC 2024


On Sat, 15 Jun 2024 05:45:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add #else branch for non-AIX platforms.
>
> test/hotspot/gtest/runtime/test_committed_virtualmemory.cpp line 218:
> 
>> 216: }
>> 217: 
>> 218: #if !defined(_WINDOWS) && !defined(_AIX)
> 
> Please also execute for windows. We should use VirtualQuery on windows, that should work.

I might be doing something wrong, but this test consistently fails on my windows machine. The full committed region is returned even if it is untouched. If I try committing a huge amount of memory (that is untouched), `os::committed_in_range `will return the full region, although actual RSS has not increased. So I think `VirtualQuery` does indeed return the amount committed, but does not distinguish between paged-in or not, which is what this test intends to check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19455#discussion_r1643016601


More information about the hotspot-runtime-dev mailing list