RFR: 8321033: Avoid casting Array to GrowableArray [v6]

[Matias Saavedra Silva]

On Sat, 15 Jun 2024 02:07:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Moved state bool into initializer list
>>  - Reverted assert
>
> src/hotspot/share/classfile/moduleEntry.cpp line 277:
> 
>> 275:     _is_open(is_open),
>> 276:     _is_patched(false),
>> 277:     DEBUG_ONLY(_reads_is_archived(false) COMMA) {
> 
> This should be
> 
> _is_patched(false)
> DEBUG_ONLY(COMMA _reads_is_archived(false)) {
> 
> Does the trailing COMMA version build?  (Either release or debug?)  I think it shouldn't, because
> in either mode there is a extraneous trailing comma that I think the compiler should reject.

No, it didn't build so I moved it to a higher spot in the initialization list. I wasn't familiar with this syntax but I think your recommendation is better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19549#discussion_r1643432576