RFR: 8332362: Implement os::committed_in_range for MacOS and AIX [v8]
Robert Toyonaga
duke at openjdk.org
Tue Jun 18 13:28:12 UTC 2024
On Mon, 17 Jun 2024 19:59:48 GMT, Robert Toyonaga <duke at openjdk.org> wrote:
>> ### Summary
>> This change adds `os::committed_in_range` to `src/hotspot/os/posix/os_posix.cpp` so that AIX and MacOS can use it. It is mostly the same as the prior implementation in `os_linux.cpp`, but takes into account AIX may have unaligned stacks and variable page sizes, and that mincore uses a different argument type on linux. This will allow AIX and MacOS to report true liveness information for thread stacks reported by NMT. Previously this was only possible on Windows and Linux.
>>
>> **Testing**
>> - `TestAlwaysPreTouchStacks.java` is updated to also test the case when stacks are large but mostly not paged in.
>> - A few new unit tests in `test_committed_virtualmemory.cpp` to check`os::committed_in_range`. I've excluded these tests on Windows because it reports the committed region as fully paged in.
>> - tier1
>>
>> I've tested on Linux and Windows. I don't have a Mac to test on, but the Mac GHA tests are passing. Not yet tested on AIX.
>
> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>
> fix trailing whitespace check.
It doesn't look like the failing test is a result of the changes in this PR.` Pre-submit tests - linux-x86 / test - Test (tier1) ` is failing because of a NPE in tools/javac/annotations/typeAnnotations/api/ArrayPositionConsistency.java related to compilation.
STDOUT:
An exception has occurred in the compiler (24-internal).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19455#issuecomment-2176100065
More information about the hotspot-runtime-dev
mailing list