RFR: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages [v2]
Joachim Kern
jkern at openjdk.org
Wed Jun 19 12:05:13 UTC 2024
On Wed, 19 Jun 2024 11:13:56 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>>
>> following Thomas proposals
>
> test/hotspot/gtest/runtime/test_os_aix.cpp line 40:
>
>> 38: #include "utilities/macros.hpp"
>> 39: #include "utilities/ostream.hpp"
>> 40: #include "unittest.hpp"
>
> Suggestion:
>
> #include "runtime/os.inline.hpp"
> #include "utilities/debug.hpp"
> #include "utilities/globalDefinitions.hpp"
> #include "unittest.hpp"
>
>
> I would guess that is all includes you really need here
Yes you're right, I had tested this out beforehand, but was reluctant and not sure if I change something not obvious with this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19771#discussion_r1646037845
More information about the hotspot-runtime-dev
mailing list