RFR: 8334489: Add function os::used_memory [v3]

Thomas Stuefe stuefe at openjdk.org
Thu Jun 20 17:01:17 UTC 2024


On Thu, 20 Jun 2024 11:39:16 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   No, not like that, like *this*
>
> src/hotspot/share/runtime/os.cpp line 2074:
> 
>> 2072:       return mem_usage;
>> 2073:     }
>> 2074:   }
> 
> I'm not sure we should introduce Linux specific things in the shared os code like that. It seems the model is to use `pd_<foo>` to delegate to platform specific code? @dholmes-ora thoughts?

I think that is okay here. Sometimes its the lesser of two evils.

I actually understood David's remark that way, too (https://github.com/openjdk/jdk/pull/19772#pullrequestreview-2127842338)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19772#discussion_r1647877550


More information about the hotspot-runtime-dev mailing list