RFR: 8321033: Avoid casting Array to GrowableArray [v10]

Kim Barrett kbarrett at openjdk.org
Fri Jun 21 23:38:10 UTC 2024


On Fri, 21 Jun 2024 15:32:42 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> `ModuleEntry::_reads` is declared as an GrowableArray<ModuleEntry*>*, but when stored in a CDS archive, it's assigned to an Array<ModuleEntry*>*. To ensure better type safety, `ModuleEntry::_reads` is changed to a generic pointer which uses two different getters and setters as well as two booleans to ensure the value is interpreted correctly. This was chosen to avoid introducing a new field to the ModuleEntry class, as another pointer and further alignment would increase the size of the ModuleEntry array. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Kim comments

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19549#pullrequestreview-2133518451


More information about the hotspot-runtime-dev mailing list