RFR: 8334357: Use NonInterleavingLogStream for report_metadata_oome

Johan Sjölen jsjolen at openjdk.org
Mon Jun 24 08:21:10 UTC 2024


On Tue, 18 Jun 2024 12:27:52 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> When `report_metadata_oome` occurs it usually occurs for multiple threads at once. Unless `tid` is used in the logging output it is very hard to understand what logging belongs together.
> 
> Log using a `NonInterleavingLogStream` so that the multi-line and multi-level logging from each thread does not get interleaved.

Marked as reviewed by jsjolen (Reviewer).

The NonInterleavingLogStream works by buffering its output before flushing to output, so is there a risk that the logging itself will fail since this is an OOME?

-------------

PR Review: https://git.openjdk.org/jdk/pull/19770#pullrequestreview-2135007356
PR Comment: https://git.openjdk.org/jdk/pull/19770#issuecomment-2185893180


More information about the hotspot-runtime-dev mailing list