RFR: 8332125: [nmt] Totals in diff report should print out total malloc and mmap diffs [v2]

Johan Sjölen jsjolen at openjdk.org
Mon Jun 24 08:53:20 UTC 2024


On Wed, 5 Jun 2024 14:07:12 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This PR addresses [8332125](https://bugs.openjdk.org/browse/JDK-8332125) enabling printing total malloc and mmap diffs when printing an NMT diff report. 
>> 
>> Testing: 
>> - [x] Added test case passes. 
>> 
>> Thanks, 
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8332125
>  - 8332125: [nmt] Totals in diff report should print out total malloc and mmap diffs

Thanks Sonia,

This seems reasonable to me and the code looks good.

All the best,
Johan

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19373#pullrequestreview-2135111106


More information about the hotspot-runtime-dev mailing list