RFR: 8334254: Cleanup CGroups initialization code

Severin Gehwolf sgehwolf at openjdk.org
Mon Jun 24 11:38:11 UTC 2024


On Sun, 23 Jun 2024 08:49:07 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> > > set_subsystem_path is only used at construction time, only call it at that time and make those functions private. Also remove virtualness, as this is unnecessary now.
> > 
> > 
> > While this is true, we want to adjust a controllers path after construction going forward. https://bugs.openjdk.org/browse/JDK-8322420 is the bug likely needing this.
> 
> Isn't this a v2 feature? `set_subsystem_path` is a v1 method.

The idea is to rework this in a version agnostic way. In essence, [JDK-8322420](https://bugs.openjdk.org/browse/JDK-8322420) and [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) solve the same problem. Therefore, they should do it the same way. E.g. by iterating over the hierarchy and determine the lowest limit across it. In order to do so, there ought to be a way to update a controller path once constructed. We can make that public again for that patch, though. HTH.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19709#issuecomment-2186366964


More information about the hotspot-runtime-dev mailing list