Integrated: 8332362: Implement os::committed_in_range for MacOS and AIX
Robert Toyonaga
duke at openjdk.org
Mon Jun 24 13:36:16 UTC 2024
On Wed, 29 May 2024 14:04:37 GMT, Robert Toyonaga <duke at openjdk.org> wrote:
> ### Summary
> This change adds `os::committed_in_range` to `src/hotspot/os/posix/os_posix.cpp` so that AIX and MacOS can use it. It is mostly the same as the prior implementation in `os_linux.cpp`, but takes into account AIX may have unaligned stacks and variable page sizes, and that mincore uses a different argument type on linux. This will allow AIX and MacOS to report true liveness information for thread stacks reported by NMT. Previously this was only possible on Windows and Linux.
>
> **Testing**
> - `TestAlwaysPreTouchStacks.java` is updated to also test the case when stacks are large but mostly not paged in.
> - A few new unit tests in `test_committed_virtualmemory.cpp` to check`os::committed_in_range`. I've excluded these tests on Windows because it reports the committed region as fully paged in.
> - tier1
>
> I've tested on Linux and Windows. I don't have a Mac to test on, but the Mac GHA tests are passing. Not yet tested on AIX.
This pull request has now been integrated.
Changeset: e825ccfe
Author: Robert Toyonaga <rtoyonag at redhat.com>
Committer: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e825ccfe6652577e4e828e8e4dfe19be0ea77813
Stats: 249 lines in 5 files changed: 160 ins; 83 del; 6 mod
8332362: Implement os::committed_in_range for MacOS and AIX
Reviewed-by: stuefe
-------------
PR: https://git.openjdk.org/jdk/pull/19455
More information about the hotspot-runtime-dev
mailing list